fix: npm init flat-options

ruyadorno · nlf · commit a0adbf9f8f77 · 2020-11-20T11:55:29.000-08:00
The `flatOptions` property exposed by `lib/npm.js` should not be redefined. This fixes an error in `npm init` by just avoiding trying to override the property there. Fixes: #2206 PR-URL: #2213 Credit: @ruyadorno Close: #2213 Reviewed-by: @nlf
diff --git a/lib/init.js b/lib/init.js
@@ -43,7 +43,6 @@ const init = async args => {
       }
     }
     npm.config.set('package', [])
-    npm.flatOptions = { ...npm.flatOptions, package: [] }
     return new Promise((res, rej) => {
       npm.commands.exec([packageName, ...args.slice(1)], er => er ? rej(er) : res())
     })
diff --git a/test/lib/init.js b/test/lib/init.js
@@ -29,7 +29,7 @@ t.afterEach(cb => {
   result = ''
   npm.config = { get: () => '', set () {} }
   npm.commands = {}
-  npm.flatOptions = {}
+  Object.defineProperty(npm, 'flatOptions', { value: {} })
   npm.log = npmLog
   cb()
 })
@@ -52,9 +52,7 @@ t.test('classic npm init -y', t => {
   npm.config = {
     get: () => '~/.npm-init.js',
   }
-  npm.flatOptions = {
-    yes: true,
-  }
+  Object.defineProperty(npm, 'flatOptions', { value: { yes: true} })
   npm.log = { ...npm.log }
   npm.log.silly = (title, msg) => {
     t.equal(title, 'package data', 'should print title')
@@ -179,6 +177,33 @@ t.test('npm init exec error', t => {
   })
 })
 
+t.test('should not rewrite flatOptions', t => {
+  t.plan(4)
+  Object.defineProperty(npm, 'flatOptions', {
+    get: () => ({}),
+    set () {
+      throw new Error('Should not set flatOptions')
+    },
+  })
+  npm.config = {
+    set (key, val) {
+      t.equal(key, 'package', 'should set package key')
+      t.deepEqual(val, [], 'should set empty array value')
+    },
+  }
+  npm.commands.exec = (arr, cb) => {
+    t.deepEqual(
+      arr,
+      ['create-react-app', 'my-app'],
+      'should npx with extra args'
+    )
+    cb()
+  }
+  init(['react-app', 'my-app'], err => {
+    t.ifError(err, 'npm init react-app')
+  })
+})
+
 t.test('npm init cancel', t => {
   t.plan(3)
   const init = requireInject('../../lib/init.js', {

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,6 @@ const init = async args => {`
`43`	`43`	`}`
`44`	`44`	`}`
`45`	`45`	`npm.config.set('package', [])`
`46`		`- npm.flatOptions = { ...npm.flatOptions, package: [] }`
`47`	`46`	`return new Promise((res, rej) => {`
`48`	`47`	`npm.commands.exec([packageName, ...args.slice(1)], er => er ? rej(er) : res())`
`49`	`48`	`})`