fix(publish): disregard deprecated versions when calculating highest version

wraithgar · wraithgar · commit 8a911ff89596 · 2025-01-17T07:31:57.000-08:00
diff --git a/lib/commands/publish.js b/lib/commands/publish.js
@@ -217,7 +217,10 @@ class Publish extends BaseCommand {
       const ordered = Object.keys(packument?.versions)
         .flatMap(v => {
           const s = new semver.SemVer(v)
-          return s.prerelease.length > 0 ? [] : s
+          if ((s.prerelease.length > 0) || packument.versions[v].deprecated) {
+            return []
+          }
+          return s
         })
         .sort((a, b) => b.compare(a))
       return ordered.length >= 1 ? ordered[0].version : null
diff --git a/test/lib/commands/publish.js b/test/lib/commands/publish.js
@@ -876,6 +876,7 @@ t.test('semver highest dist tag', async t => {
     // this needs more than one item in it to cover the sort logic
     { version: '50.0.0' },
     { version: '100.0.0' },
+    { version: '102.0.0', deprecated: 'oops' },
     { version: '105.0.0-pre' },
   ]
 

Original file line number	Diff line number	Diff line change
`@@ -876,6 +876,7 @@ t.test('semver highest dist tag', async t => {`
`876`	`876`	`// this needs more than one item in it to cover the sort logic`
`877`	`877`	`{ version: '50.0.0' },`
`878`	`878`	`{ version: '100.0.0' },`
	`879`	`+ { version: '102.0.0', deprecated: 'oops' },`
`879`	`880`	`{ version: '105.0.0-pre' },`
`880`	`881`	`]`
`881`	`882`