fix: only add directories we made to _sparseTreeRoots (#6222)

nlf · web-flow · commit 8a78c6fc400e · 2023-03-08T10:34:29.000-07:00
diff --git a/workspaces/arborist/lib/arborist/reify.js b/workspaces/arborist/lib/arborist/reify.js
@@ -535,9 +535,14 @@ module.exports = cls => class Reifier extends cls {
           await this[_renamePath](d, retired)
         }
       }
-      const made = await mkdir(node.path, { recursive: true })
       this[_sparseTreeDirs].add(node.path)
-      this[_sparseTreeRoots].add(made)
+      const made = await mkdir(node.path, { recursive: true })
+      // if the directory already exists, made will be undefined. if that's the case
+      // we don't want to remove it because we aren't the ones who created it so we
+      // omit it from the _sparseTreeRoots
+      if (made) {
+        this[_sparseTreeRoots].add(made)
+      }
     }))
       .then(() => process.emit('timeEnd', 'reify:createSparse'))
   }

Original file line number	Diff line number	Diff line change
`@@ -535,9 +535,14 @@ module.exports = cls => class Reifier extends cls {`
`535`	`535`	`await this[_renamePath](d, retired)`
`536`	`536`	`}`
`537`	`537`	`}`
`538`		`- const made = await mkdir(node.path, { recursive: true })`
`539`	`538`	`this[_sparseTreeDirs].add(node.path)`
`540`		`- this[_sparseTreeRoots].add(made)`
	`539`	`+ const made = await mkdir(node.path, { recursive: true })`
	`540`	`+ // if the directory already exists, made will be undefined. if that's the case`
	`541`	`+ // we don't want to remove it because we aren't the ones who created it so we`
	`542`	`+ // omit it from the _sparseTreeRoots`
	`543`	`+ if (made) {`
	`544`	`+ this[_sparseTreeRoots].add(made)`
	`545`	`+ }`
`541`	`546`	`}))`
`542`	`547`	`.then(() => process.emit('timeEnd', 'reify:createSparse'))`
`543`	`548`	`}`