Skip to content

Commit 6642613

Browse files
authored
chore: drop clinic and weak from node-integration knownFailures
1 parent fc517df commit 6642613

2 files changed

Lines changed: 0 additions & 4 deletions

File tree

‎.github/workflows/node-integration.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,14 +280,12 @@ jobs:
280280
// this is a manually updated list of packages that we know currently fail
281281
const knownFailures = [
282282
'body-parser', // json parsing error difference
283-
'clinic', // unknown, lots of failures
284283
'ember-cli', // timeout in nodejs ci, one failing test for us that timed out
285284
'express', // body-parser is what actually fails, it's used in a test
286285
'https-proxy-agent', // looks ssl related
287286
'node-gyp', // one test consistently times out
288287
'resolve', // compares results to require.resolve and fails, also missing inspector/promises
289288
'uuid', // tests that crypto.getRandomValues throws but it doesn't
290-
'weak', // doesn't seem to build in node >12
291289
'mkdirp', // failing actions in own repo
292290
'undici', // test failure in node >=18, unable to root cause
293291
]

‎scripts/template-oss/node-integration-yml.hbs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,14 +278,12 @@ jobs:
278278
// this is a manually updated list of packages that we know currently fail
279279
const knownFailures = [
280280
'body-parser', // json parsing error difference
281-
'clinic', // unknown, lots of failures
282281
'ember-cli', // timeout in nodejs ci, one failing test for us that timed out
283282
'express', // body-parser is what actually fails, it's used in a test
284283
'https-proxy-agent', // looks ssl related
285284
'node-gyp', // one test consistently times out
286285
'resolve', // compares results to require.resolve and fails, also missing inspector/promises
287286
'uuid', // tests that crypto.getRandomValues throws but it doesn't
288-
'weak', // doesn't seem to build in node >12
289287
'mkdirp', // failing actions in own repo
290288
'undici', // test failure in node >=18, unable to root cause
291289
]

0 commit comments

Comments
 (0)