fix(arborist): add missing top property to isolated reifier proxy nodes (#9064)

manzoorwanijk · web-flow · commit 2d832315d676 · 2026-03-05T09:07:52.000-08:00
diff --git a/workspaces/arborist/lib/arborist/isolated-reifier.js b/workspaces/arborist/lib/arborist/isolated-reifier.js
@@ -318,6 +318,7 @@ module.exports = cls => class IsolatedReifier extends cls {
     }
     root.inventory.set('', root)
     root.root = root
+    root.top = root
     root.target = root
     // TODO inventory.query is a stub; audit-report needs 'packageName' support
     root.inventory.query = () => {
@@ -335,6 +336,7 @@ module.exports = cls => class IsolatedReifier extends cls {
         hasInstallScript: c.hasInstallScript,
         isLink: false,
         isRoot: false,
+        isWorkspace: true,
         linksIn: new Set(),
         location: c.localLocation,
         name: wsName,
@@ -344,6 +346,7 @@ module.exports = cls => class IsolatedReifier extends cls {
         resolved: c.resolved,
       }
       workspace.target = workspace
+      workspace.top = workspace
       root.fsChildren.add(workspace)
       root.inventory.set(workspace.location, workspace)
 
@@ -369,6 +372,7 @@ module.exports = cls => class IsolatedReifier extends cls {
         realpath: workspace.path,
         root,
         target: workspace,
+        top: root,
       }
       root.children.set(wsLink.name, wsLink)
       root.inventory.set(wsLink.location, wsLink)
diff --git a/workspaces/arborist/test/arborist/reify.js b/workspaces/arborist/test/arborist/reify.js
@@ -3250,4 +3250,51 @@ t.test('install stategy linked', async (t) => {
     t.ok(store.isDirectory(), 'abbrev got installed')
     t.ok(abbrev.isSymbolicLink(), 'abbrev got installed')
   })
+
+  t.test('should not crash with --omit=dev in workspaces', async (t) => {
+    const testdir = t.testdir({
+      project: {
+        'package.json': JSON.stringify({
+          name: 'my-monorepo',
+          version: '1.0.0',
+          workspaces: ['packages/*'],
+          dependencies: {
+            abbrev: '1.1.1',
+          },
+          devDependencies: {
+            abbrev: '1.1.1',
+          },
+        }),
+        packages: {
+          'my-lib': {
+            'package.json': JSON.stringify({
+              name: 'my-lib',
+              version: '1.0.0',
+              dependencies: {
+                abbrev: '1.1.1',
+              },
+            }),
+          },
+        },
+      },
+    })
+
+    tnock(t, 'https://registry.npmjs.org')
+      .get('/abbrev')
+      .reply(200, abbrevPackument)
+
+    tnock(t, 'https://registry.npmjs.org')
+      .get('/abbrev/-/abbrev-1.1.1.tgz')
+      .reply(200, abbrevTGZ)
+
+    const path = resolve(testdir, 'project')
+    const arb = new Arborist({
+      path,
+      registry: 'https://registry.npmjs.org',
+      cache: resolve(testdir, 'cache'),
+      installStrategy: 'linked',
+    })
+    await arb.reify({ installStrategy: 'linked', omit: ['dev'] })
+    t.pass('reify with --omit=dev did not crash')
+  })
 })
