npm ci should never save package.json or lockfile

isaacs · isaacs · commit 24f3a5448f02 · 2020-09-16T15:14:31.000-07:00
Via: https://github.com/targos/npm7-cra#issue-1-npm-ci-changes-packagejson
diff --git a/lib/ci.js b/lib/ci.js
@@ -33,7 +33,8 @@ const ci = async () => {
     }),
     rimraf(`${where}/node_modules/`)
   ])
-  await arb.reify()
+  // npm ci should never modify the lockfile or package.json
+  await arb.reify({ save: false })
   reifyOutput(arb)
 }
 
diff --git a/test/lib/ci.js b/test/lib/ci.js
@@ -100,7 +100,8 @@ test('should remove existing node_modules before installing', (t) => {
     },
     '@npmcli/arborist': function () {
       this.loadVirtual = () => Promise.resolve(true)
-      this.reify = async () => {
+      this.reify = async (options) => {
+        t.equal(options.save, false, 'npm ci should never save')
         // check if node_modules was removed before reifying
         const contents = await readdir(testDir)
         t.equals(contents.indexOf('node_modules'), -1, 'node_modules does not exist')

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,8 @@ const ci = async () => {`
`33`	`33`	`}),`
`34`	`34`	rimraf(`${where}/node_modules/`)
`35`	`35`	`])`
`36`		`- await arb.reify()`
	`36`	`+ // npm ci should never modify the lockfile or package.json`
	`37`	`+ await arb.reify({ save: false })`
`37`	`38`	`reifyOutput(arb)`
`38`	`39`	`}`
`39`	`40`