send json errors to stderr, not stdout

isaacs · isaacs · commit 1dbf0f9bb26b · 2020-11-13T11:22:56.000-08:00
Fixes: #2150 Credit: @isaacs Close: #2155 Reviewed-by: @ruyadorno
diff --git a/lib/utils/error-handler.js b/lib/utils/error-handler.js
@@ -182,7 +182,7 @@ const errorHandler = (er) => {
         detail: messageText(msg.detail),
       },
     }
-    console.log(JSON.stringify(error, null, 2))
+    console.error(JSON.stringify(error, null, 2))
   }
 
   exit(typeof er.errno === 'number' ? er.errno : typeof er.code === 'number' ? er.code : 1)
diff --git a/test/lib/utils/error-handler.js b/test/lib/utils/error-handler.js
@@ -218,8 +218,8 @@ t.test('console.log output using --json', (t) => {
 
   config.values.json = true
 
-  const _log = console.log
-  console.log = (jsonOutput) => {
+  const _error = console.error
+  console.error = (jsonOutput) => {
     t.deepEqual(
       JSON.parse(jsonOutput),
       {
@@ -236,7 +236,7 @@ t.test('console.log output using --json', (t) => {
   errorHandler(new Error('Error: EBADTHING Something happened'))
 
   t.teardown(() => {
-    console.log = _log
+    console.error = _error
     delete config.values.json
   })
 })

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ const errorHandler = (er) => {`
`182`	`182`	`detail: messageText(msg.detail),`
`183`	`183`	`},`
`184`	`184`	`}`
`185`		`- console.log(JSON.stringify(error, null, 2))`
	`185`	`+ console.error(JSON.stringify(error, null, 2))`
`186`	`186`	`}`
`187`	`187`
`188`	`188`	`exit(typeof er.errno === 'number' ? er.errno : typeof er.code === 'number' ? er.code : 1)`