Repository navigation
Commit 18b930f
authored
fix(exec): prevent shared binPaths pollution across workspace runs (#9650)
**Description:**
related: #9640
**Bug:**
When running `npm exec` across multiple workspaces, the binary from the
first workspace would accidentally bleed into the second one if they
shared the same name.
**Root Cause:**
In `libnpmexec`, the `binPaths` array was scoped at the module level
instead of inside the `exec()` function. Since `execWorkspaces` runs
everything in a single process, `binPaths` just kept accumulating paths.
When the second workspace ran, the first workspace's `.bin` path was
still sitting at the front of `PATH`, so it hijacked the execution.
**Fix:**
Moved `binPaths` inside `exec()` so it gets a fresh array on every call.
I left the `manifests` map at the module level (keyed by `spec.raw`)
because we still want to cache registry specs across calls, and absolute
paths won't collide anyway.
**Testing:**
- Added a regression test in `test/local.js` with two workspaces using
the exact same local bin name (`shared-bin`).
- Gave each test call its own `args` array to stop `@npmcli/run-script`
from mutating it and hanging the tests.
- Fails correctly without the fix. With the fix, all tests pass 100%.1 parent 6da6555 commit 18b930f
2 files changed
Lines changed: 70 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
24 | 22 | | |
25 | 23 | | |
26 | 24 | | |
| |||
113 | 111 | | |
114 | 112 | | |
115 | 113 | | |
| 114 | + | |
| 115 | + | |
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| |||
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
199 | | - | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
200 | 204 | | |
201 | 205 | | |
202 | 206 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
469 | 469 | | |
470 | 470 | | |
471 | 471 | | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
0 commit comments