fix pulseWhileDone promise handling

isaacs · isaacs · commit 10fcff73a338 · 2020-08-20T17:46:01.000-07:00
Small an oversight from the Bluebird -> Promise refactor. Fix #1695
diff --git a/lib/utils/pulse-till-done.js b/lib/utils/pulse-till-done.js
@@ -25,18 +25,17 @@ module.exports = function (prefix, cb) {
     cb(er, ...args)
   }
 }
-module.exports.withPromise = pulseWhile
 
-function pulseWhile (prefix, promise) {
+const pulseWhile = async (prefix, promise) => {
   if (!promise) {
     promise = prefix
     prefix = ''
   }
   pulseStart(prefix)
-  return Promise.resolve(promise)
-    .then(() => pulseStop())
-    .catch(er => {
-      pulseStop()
-      throw er
-    })
+  try {
+    return await promise
+  } finally {
+    pulseStop()
+  }
 }
+module.exports.withPromise = pulseWhile
