pack: set correct filename for scoped packages

isaacs · isaacs · commit 0808328c93d9 · 2020-08-04T17:03:46.000-07:00
This should probably be done in libnpmpack.  Can be removed
from here when it is.
diff --git a/lib/pack.js b/lib/pack.js
@@ -27,7 +27,7 @@ const pack = async (args) => {
 
   for (const tar of tarballs) {
     logTar(tar, { log, unicode })
-    output(tar.filename)
+    output(tar.filename.replace(/^@/, '').replace(/\//, '-'))
   }
 }
 
@@ -36,6 +36,7 @@ const pack_ = async (arg, opts) => {
   const { dryRun } = opts
   const manifest = await pacote.manifest(spec, opts)
   const filename = `${manifest.name}-${manifest.version}.tgz`
+    .replace(/^@/, '').replace(/\//, '-')
   const tarballData = await libpack(arg, opts)
   const pkgContents = await getContents(manifest, tarballData)
 
diff --git a/test/lib/pack.js b/test/lib/pack.js
@@ -78,6 +78,40 @@ t.test('should pack given directory', (t) => {
   })
 })
 
+t.test('should pack given directory for scoped package', (t) => {
+  const testDir = t.testdir({
+    'package.json': JSON.stringify({
+      name: '@cool/my-pkg',
+      version: '1.0.0'
+    }, null, 2)
+  })
+
+  const pack = requireInject('../../lib/pack.js', {
+    '../../lib/utils/output.js': output,
+    '../../lib/npm.js': {
+      flatOptions: {
+        unicode: true,
+        json: true,
+        dryRun: true
+      }
+    },
+    libnpmpack,
+    npmlog: {
+      notice: () => {},
+      'showProgress': () => {},
+      'clearProgress': () => {}
+    }
+  })
+
+  return pack([testDir], er => {
+    if (er) {
+      throw er
+    }
+    const filename = 'cool-my-pkg-1.0.0.tgz'
+    t.strictSame(OUTPUT, [[filename]])
+  })
+})
+
 t.test('should log pack contents', (t) => {
   const pack = requireInject('../../lib/pack.js', {
     '../../lib/utils/output.js': output,

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ const pack = async (args) => {`
`27`	`27`
`28`	`28`	`for (const tar of tarballs) {`
`29`	`29`	`logTar(tar, { log, unicode })`
`30`		`- output(tar.filename)`
	`30`	`+ output(tar.filename.replace(/^@/, '').replace(/\//, '-'))`
`31`	`31`	`}`
`32`	`32`	`}`
`33`	`33`
`@@ -36,6 +36,7 @@ const pack_ = async (arg, opts) => {`
`36`	`36`	`const { dryRun } = opts`
`37`	`37`	`const manifest = await pacote.manifest(spec, opts)`
`38`	`38`	const filename = `${manifest.name}-${manifest.version}.tgz`
	`39`	`+ .replace(/^@/, '').replace(/\//, '-')`
`39`	`40`	`const tarballData = await libpack(arg, opts)`
`40`	`41`	`const pkgContents = await getContents(manifest, tarballData)`
`41`	`42`