Skip to content
This repository was archived by the owner on Apr 19, 2023. It is now read-only.
This repository was archived by the owner on Apr 19, 2023. It is now read-only.

[BUG] False negatives in Jenkins CI #47

@kanadgupta

Description

@kanadgupta

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Right now, the Jenkins Pipeline detection solely relies on the existence of JENKINS_URL variable. Per the Jenkins docs:

(NOTE: only available if Jenkins URL set in "System Configuration")

For users that don't configure the Jenkins URL for their CI pipeline, this package returns a false negative.

Expected Behavior

This package should always return true for Jenkins CI, so I propose adding a check for the BUILD_ID variable as an additional check for Jenkins since that value should always be there in Jenkins CI. This is what ci-info does: https://github.com/watson/ci-info/blob/master/vendors.json#L135

Steps To Reproduce

No response

Environment

  • npm: 8.19.3
  • Node: 16.14.0
  • OS: macOS
  • platform: MacBook Pro

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bugthing that needs fixingNeeds Triageneeds an initial review

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions