Add back parameterless overload of ReloadTypesAsync#6522
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restores the parameterless NpgsqlConnection.ReloadTypesAsync() overload to address a binary compatibility break introduced when the API was changed to only expose a CancellationToken overload.
Changes:
- Reintroduces
NpgsqlConnection.ReloadTypesAsync()and forwards it to the token-based overload. - Updates PublicAPI files to reflect the restored overload and adjust the recorded API surface accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Npgsql/NpgsqlConnection.cs |
Adds back the parameterless ReloadTypesAsync() overload and forwards to the token overload. |
src/Npgsql/PublicAPI.Shipped.txt |
Records the ReloadTypesAsync(CancellationToken) overload in the shipped API surface. |
src/Npgsql/PublicAPI.Unshipped.txt |
Removes the prior “removed API” marker for the parameterless overload and updates tracked entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vonzshik
approved these changes
Apr 3, 2026
roji
added a commit
that referenced
this pull request
Apr 3, 2026
(cherry picked from commit 3698a47)
roji
added a commit
that referenced
this pull request
Apr 3, 2026
(cherry picked from commit 3698a47)
Member
Author
roji
added a commit
that referenced
this pull request
Apr 4, 2026
Move API changes from commits after v10.0.0 back to Unshipped, as they represent 11.0 work, not 10.0: - Remove multiplexing (#6457): 4 *REMOVED* entries - Remove large object API (#6493): 37 *REMOVED* entries - Add back parameterless ReloadTypesAsync (#6522): undo the v10.0 addition of CancellationToken overload and re-add the parameterless overload Also adjusts Shipped to correctly reflect the v10.0.0 public API. Co-authored-by: Copilot <[email protected]>
roji
added a commit
that referenced
this pull request
Apr 4, 2026
Move API changes from commits after v10.0.0 back to Unshipped, as they represent 11.0 work, not 10.0: - Remove multiplexing (#6457): 4 *REMOVED* entries - Remove large object API (#6493): 37 *REMOVED* entries - Add back parameterless ReloadTypesAsync (#6522): undo the v10.0 addition of CancellationToken overload and re-add the parameterless overload Also adjusts Shipped to correctly reflect the v10.0.0 public API. Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5919 caused a binary break by replaceing
NpgsqlConnection.ReloadTypesAsync()withReloadTypesAsync(CancellationToken); this notably blocks people from using the PostgreSQL MEVD provider - which is compiled against Npgsql 8.0 (to be netfx-compatible) - with Npgsql 10.0.