Remove the obsoleted large object API#6493
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes Npgsql’s built-in PostgreSQL large object (LO) API surface (previously marked obsolete) and updates the public API baselines accordingly.
Changes:
- Removed
NpgsqlLargeObjectManagerandNpgsqlLargeObjectStreamimplementations fromsrc/Npgsql. - Removed the associated LO test coverage (
LargeObjectTests). - Added
*REMOVED*entries toPublicAPI.Unshipped.txtto reflect the public API break.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/Npgsql.Tests/LargeObjectTests.cs | Removes tests which exercised the removed LO manager/stream APIs. |
| src/Npgsql/PublicAPI.Unshipped.txt | Marks the LO manager/stream types and members as removed in the public API change log. |
| src/Npgsql/NpgsqlLargeObjectStream.cs | Deletes the LO stream implementation. |
| src/Npgsql/NpgsqlLargeObjectManager.cs | Deletes the LO manager implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
NinoFloris
approved these changes
Mar 13, 2026
NinoFloris
left a comment
NinoFloris
left a comment
Member
There was a problem hiding this comment.
Zero internal uses too, good riddance :)
roji
added a commit
to roji/Npgsql.Doc
that referenced
this pull request
Mar 13, 2026
Also add breaking change note for multiplexing See npgsql/npgsql#6493
roji
added a commit
to npgsql/doc
that referenced
this pull request
Mar 13, 2026
Also add breaking change note for multiplexing See npgsql/npgsql#6493
roji
added a commit
that referenced
this pull request
Apr 4, 2026
Move API changes from commits after v10.0.0 back to Unshipped, as they represent 11.0 work, not 10.0: - Remove multiplexing (#6457): 4 *REMOVED* entries - Remove large object API (#6493): 37 *REMOVED* entries - Add back parameterless ReloadTypesAsync (#6522): undo the v10.0 addition of CancellationToken overload and re-add the parameterless overload Also adjusts Shipped to correctly reflect the v10.0.0 public API. Co-authored-by: Copilot <[email protected]>
roji
added a commit
that referenced
this pull request
Apr 4, 2026
Move API changes from commits after v10.0.0 back to Unshipped, as they represent 11.0 work, not 10.0: - Remove multiplexing (#6457): 4 *REMOVED* entries - Remove large object API (#6493): 37 *REMOVED* entries - Add back parameterless ReloadTypesAsync (#6522): undo the v10.0 addition of CancellationToken overload and re-add the parameterless overload Also adjusts Shipped to correctly reflect the v10.0.0 public API. Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6492