Fix possible protocol desync with SchemaOnly and auto prepare#5221
Merged
Fix possible protocol desync with SchemaOnly and auto prepare#5221
Conversation
vonzshik
commented
Aug 25, 2023
| throw Connector.UnexpectedMessageReceived(msg.Code); | ||
| } | ||
|
|
||
| if (_statements.Skip(StatementIndex + 1).All(x => x.IsPrepared)) |
Contributor
Author
There was a problem hiding this comment.
cc @NinoFloris added linq here (which from what I aware you removed in separate pr)
Would prefer to leave as is in this pr to make it a bit easier to backport.
Member
There was a problem hiding this comment.
Sure, I'll have to rebase the rework at least once more anyway
NinoFloris
approved these changes
Aug 25, 2023
Member
NinoFloris
left a comment
NinoFloris
left a comment
There was a problem hiding this comment.
Alright let's merge it in. Will rebase on top of all of this
vonzshik
added a commit
that referenced
this pull request
Aug 25, 2023
vonzshik
added a commit
that referenced
this pull request
Aug 25, 2023
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5220