Treat pg_users.user_sysid as uint rather than int#5057
Merged
roji merged 1 commit intonpgsql:mainfrom May 16, 2023
Merged
Conversation
The data in this field can be in the range of 0 to 4,294,967,295. Before this patch, if there was a value larger than 2,147,483,647 this operation would fail with the following error. System.ArgumentException : Value was either too large or too small for an Int32.Couldn't store <3233629770> in user_sysid Column. Expected type is Int32. at System.Data.DataColumn.set_Item(Int32 record, Object value) at System.Data.DataTable.NewRecordFromArray(Object[] value) at System.Data.DataTable.LoadDataRow(Object[] values, Boolean fAcceptChanges) at Npgsql.NpgsqlDataAdapter.Fill(DataTable dataTable, NpgsqlDataReader dataReader, Boolean async, CancellationToken cancellationToken) in /mnt/data1/npgsql/src/Npgsql/NpgsqlDataAdapter.cs:line 199 at Npgsql.NpgsqlDataAdapter.Fill(DataTable dataTable, Boolean async, CancellationToken cancellationToken) in /mnt/data1/npgsql/src/Npgsql/NpgsqlDataAdapter.cs:line 158 at Npgsql.NpgsqlDataAdapter.Fill(DataTable dataTable, Boolean async, CancellationToken cancellationToken) in /mnt/data1/npgsql/src/Npgsql/NpgsqlDataAdapter.cs:line 166 at Npgsql.NpgsqlSchema.GetUsers(NpgsqlConnection conn, String[] restrictions, Boolean async, CancellationToken cancellationToken) in /mnt/data1/npgsql/src/Npgsql/NpgsqlSchema.cs:line 304 at Npgsql.Tests.SchemaTests.GetSchema(NpgsqlConnection conn, String collectionName) in /mnt/data1/npgsql/test/Npgsql.Tests/SchemaTests.cs:line 545
roji
pushed a commit
that referenced
this pull request
May 16, 2023
(cherry picked from commit 60c4f52)
Member
roji
pushed a commit
that referenced
this pull request
May 16, 2023
(cherry picked from commit 60c4f52)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data in this field can be in the range of 0 to 4,294,967,295. Before this patch, if there was a value larger than 2,147,483,647 this operation would fail with the following error.