FIx multiple hosts with disabled sql rewriting#5056
Merged
Conversation
roji
approved these changes
May 12, 2023
| public async Task Multiple_hosts_with_disabled_sql_rewriting() | ||
| { | ||
| using var _ = DisableSqlRewriting(); | ||
| PoolManager.Reset(); |
Member
There was a problem hiding this comment.
nit: we could move this into DisableSqlRewriting
Contributor
Author
There was a problem hiding this comment.
Sure, just was thinking that having this in MultipleHostsTests is a bit more appropriate.
Contributor
Author
There was a problem hiding this comment.
Ah, you mean to move PoolManager.Reset?
Member
There was a problem hiding this comment.
Sure. Was just saying that we probably want to clear the pool wherever we have a test doing such a global change etc.
Contributor
Author
There was a problem hiding this comment.
OK, can do. The only reason I added PoolManager.Reset is because I copy-pasted from IntegrationTest above (it was required because we were caching cluster's state globally, and now it's probably not needed anymore).
vonzshik
added a commit
that referenced
this pull request
May 12, 2023
vonzshik
added a commit
that referenced
this pull request
May 12, 2023
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5055