Remove geometry type regex parsing logic#4902
Merged
roji merged 1 commit intonpgsql:mainfrom Jan 23, 2023
Merged
Conversation
And also pgpass-related regex use Closes npgsql#4896
gfoidl
reviewed
Jan 23, 2023
| goto Finish; | ||
| ch = value[pos]; | ||
| if (ch == '*') | ||
| switch (ch) |
Contributor
There was a problem hiding this comment.
Is this hot enough to
Suggested change
| switch (ch) | |
| switch (ch | 0x20) |
so to have the cases only for lowercase chars, thus saving some branches and code-size?
See sharplab
Member
Author
There was a problem hiding this comment.
I definitely don't think this code is hot enough for micro-optimization.. In fact, we should consider removing the parsing logic altogether, as this PR does for the geometry types.
vonzshik
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And also pgpass-related regex use
Closes #4896