Skip to content

Set a valid activity span name in NpgsqlActivitySource.CommandStart#4765

Merged
Brar merged 6 commits intonpgsql:mainfrom
Brar:BetterOpenTelemetrySpanName
Nov 17, 2022
Merged

Set a valid activity span name in NpgsqlActivitySource.CommandStart#4765
Brar merged 6 commits intonpgsql:mainfrom
Brar:BetterOpenTelemetrySpanName

Conversation

@Brar
Copy link
Copy Markdown
Member

@Brar Brar commented Nov 16, 2022

Fixes #4757

@Brar Brar requested review from roji and vonzshik as code owners November 16, 2022 17:44
Comment thread src/Npgsql/NpgsqlActivitySource.cs Outdated
Copy link
Copy Markdown
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the extra data for other CommandTypes!

BTW "one day" we should really add some testing around this (#4285)

Comment thread src/Npgsql/NpgsqlActivitySource.cs Outdated
Comment thread src/Npgsql/NpgsqlActivitySource.cs Outdated
Comment thread src/Npgsql/NpgsqlActivitySource.cs
Comment thread src/Npgsql/Internal/NpgsqlConnector.cs Outdated
@Brar Brar merged commit 031a36a into npgsql:main Nov 17, 2022
Brar added a commit that referenced this pull request Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenTelemetry Protocol cannot export spans with empty display name

3 participants