Clean up and expose physical connection initializers#4678
Merged
roji merged 1 commit intonpgsql:mainfrom Oct 15, 2022
Merged
Conversation
roji
force-pushed
the
ConnectionInitializers
branch
from
91173fa to
9400c48
Compare
Member
Author
|
BTW I did have one thought when doing this - we could allow several separate connection initializers to be added, and "aggregate" them into a single function. This would mainly mean changing the NpgsqlDataSourceBuilder API (e.g. AddConnectionInitializer, ResetConnectionInitializer). But this is such a fringe API that it seems really overkill. |
roji
force-pushed
the
ConnectionInitializers
branch
2 times, most recently
from
bdfa19c to
95366ac
Compare
roji
force-pushed
the
ConnectionInitializers
branch
from
95366ac to
1bd6d36
Compare
vonzshik
reviewed
Oct 3, 2022
NinoFloris
reviewed
Oct 14, 2022
Member
NinoFloris
left a comment
NinoFloris
left a comment
There was a problem hiding this comment.
Some naming feedback, otherwise LGTM
| } | ||
| } | ||
|
|
||
| internal void MakeDisposed() |
roji
force-pushed
the
ConnectionInitializers
branch
from
7f87d49 to
a3ed18b
Compare
NinoFloris
approved these changes
Oct 15, 2022
roji
force-pushed
the
ConnectionInitializers
branch
from
a3ed18b to
edc9c63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@NinoFloris this one's for you.
Note that during the physical initialization phase, there's no multiplexing - the connection is bound to the connector (this is kinda obvious since the whole point is to do initialization on a physical connection).
The relationalship between connection and connector is ever annoying... Oh well.
Closes #3817
Closes #3745