Fix auto-preparation with SchemaOnly#4420
Merged
roji merged 1 commit intonpgsql:mainfrom Apr 17, 2022
Merged
Conversation
vonzshik
approved these changes
Apr 17, 2022
Member
Author
|
Backported to 6.0.4 via 12f1677 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4404
I debated whether to simply not auto-prepare for SchemaOnly, but finally decided it's an "execution" just like any other (and I'd rather not introduce more checks in the critical path because of SchemaOnly). But if you think we should go the other way I'm open to that too...
In any case, at some point we should look at maybe refactoring NpgsqlDataReader.{NextResult,NextResultSchemaOnly} since they contain lots of duplication.