Refactor DefaultTypeHandlerFactory to remove reflection#3818
Merged
Conversation
As part of this, PostgresType can now be injected into handlers after construction. Closes #3815
vonzshik
reviewed
Jun 6, 2021
vonzshik
approved these changes
Jun 6, 2021
NinoFloris
approved these changes
Jun 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of this, PostgresType can now be injected into handlers after construction.
Closes #3815
Note: after this PR, some handlers accept the PG type in the constructor, and others get it injected later. This inconsistency isn't ideal, but it isn't too bad (it's ultimately the handler factory's responsibility to make sure the PostgresType is set).