Fix adding to hash lookup while renaming an unnamed parameter (#6073)

vonzshik · vonzshik · commit d1191758398d · 2025-03-26T14:26:26.000+03:00
Fixes #6067 (cherry picked from commit ef219b7)
diff --git a/src/Npgsql/NpgsqlParameterCollection.cs b/src/Npgsql/NpgsqlParameterCollection.cs
@@ -143,7 +143,7 @@ internal void ChangeParameterName(NpgsqlParameter parameter, string? value)
         var oldTrimmedName = parameter.TrimmedName;
         parameter.ChangeParameterName(value);
 
-        if (_caseInsensitiveLookup is null || _caseInsensitiveLookup.Count == 0)
+        if (_caseInsensitiveLookup is null)
             return;
 
         var index = IndexOf(parameter);
diff --git a/test/Npgsql.Tests/NpgsqlParameterCollectionTests.cs b/test/Npgsql.Tests/NpgsqlParameterCollectionTests.cs
@@ -71,6 +71,34 @@ public void Hash_lookup_parameter_rename_bug()
         Assert.That(command.Parameters.IndexOf("a_new_name"), Is.GreaterThanOrEqualTo(0));
     }
 
+    [Test]
+    [IssueLink("https://github.com/npgsql/npgsql/issues/6067")]
+    public void Hash_lookup_unnamed_parameter_rename_bug()
+    {
+        if (_compatMode == CompatMode.TwoPass)
+            return;
+
+        using var command = new NpgsqlCommand();
+
+        for (var i = 0; i < 3; i++)
+        {
+            // Put plenty of parameters in the collection to turn on hash lookup functionality.
+            for (var j = 0; j < LookupThreshold; j++)
+            {
+                // Create and add an unnamed parameter before renaming it
+                var parameter = command.CreateParameter();
+                command.Parameters.Add(parameter);
+                parameter.ParameterName = $"{j}";
+            }
+
+            // Make sure hash lookup is generated.
+            Assert.AreEqual(command.Parameters["3"].ParameterName, "3");
+
+            // Remove all parameters to clear hash lookup
+            command.Parameters.Clear();
+        }
+    }
+
     [Test]
     public void Remove_duplicate_parameter([Values(LookupThreshold, LookupThreshold - 2)] int count)
     {
