Fixes Kurdish lam-alef ligature in Noto Sans Arabic UI fonts#281
Open
mapmeld wants to merge 2 commits intonotofonts:mainfrom
Open
Fixes Kurdish lam-alef ligature in Noto Sans Arabic UI fonts#281mapmeld wants to merge 2 commits intonotofonts:mainfrom
mapmeld wants to merge 2 commits intonotofonts:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team - the OpenStreetMap project uses Noto fonts on most map tiles. For some time they've had an issue with about 1,000 place names in the Kurdish region which use ڵا , a three-character ligature (original Noto issue: #8 )
This got fixed in Noto Arabic, but not in the UI fonts, which I heard were deprecated.
Admin was concerned that changing to the current Noto Arabic fonts would have larger effects such as line-height.
Last year I reviewed the fix to ligatures in the main Noto Sans font (added anchors, rewritten ligature rules), and applied them to the UI font. You can see my font here: https://mapmeld.com/arabic/index.html
I've put the changes into this PR. One issue which I couldn't resolve, is I had to turn off variable fonts on the UI font for the bolder and lighter fonts to build the new anchors correctly. I am new to the fonts world, so if you can flag what might be causing this issue, I'm happy to go back and review.
Sample error when variable fonts is on: