Skip to content

Comments

fix(fsevent): do not panic on invalid inputs#790

Merged
JohnTitor merged 2 commits intonotify-rs:mainfrom
JohnTitor:fix-panic
Feb 7, 2026
Merged

fix(fsevent): do not panic on invalid inputs#790
JohnTitor merged 2 commits intonotify-rs:mainfrom
JohnTitor:fix-panic

Conversation

@JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Feb 6, 2026

Description

  • Do not panic the process itself when FSEvents callback panics.
  • Account for non UTF-8 paths, recent macOS enforces UTF-8 on creation but files from other systems like NFS could cause the issue.

Related Issues

@JohnTitor JohnTitor force-pushed the fix-panic branch 2 times, most recently from 8290c06 to c320a3c Compare February 7, 2026 00:00
@JohnTitor JohnTitor changed the title ci fix(fsevent): do not panic on invalid inputs Feb 7, 2026
@JohnTitor JohnTitor marked this pull request as ready for review February 7, 2026 01:40
@JohnTitor JohnTitor merged commit abd1776 into notify-rs:main Feb 7, 2026
1 of 4 checks passed
@JohnTitor JohnTitor deleted the fix-panic branch February 7, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant