Implement EventHandler for futures and tokio UnboundedSender#767
Merged
JohnTitor merged 3 commits intonotify-rs:mainfrom Jan 29, 2026
Merged
Implement EventHandler for futures and tokio UnboundedSender#767JohnTitor merged 3 commits intonotify-rs:mainfrom
JohnTitor merged 3 commits intonotify-rs:mainfrom
Conversation
JohnTitor
reviewed
Jan 29, 2026
notify-debouncer-full/src/lib.rs
Outdated
| .expect("error"); | ||
| } | ||
|
|
||
| #[cfg(feature = "futures")] |
Member
There was a problem hiding this comment.
Should be:
Suggested change
| #[cfg(feature = "futures")] | |
| #[cfg(feature = "tokio")] |
Other tests for tokio has the same left-over.
Contributor
Author
There was a problem hiding this comment.
Thanks! Fixed
Additionally, tried to fix other PollWatcher tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
EventHandler(notify, debouncer-full and mini) for tokio and futures UnboundedSender behind the feature flagsfuturesandtokio