Skip to content

Comments

Fix: throw fsevents stream start error properly#733

Merged
JohnTitor merged 4 commits intonotify-rs:mainfrom
sapphi-red:fix/throw-fsevents-stream-start-error-properly
Jan 14, 2026
Merged

Fix: throw fsevents stream start error properly#733
JohnTitor merged 4 commits intonotify-rs:mainfrom
sapphi-red:fix/throw-fsevents-stream-start-error-properly

Conversation

@sapphi-red
Copy link
Contributor

fsevents seems to not allow watching more than 4096 paths at once.
But notify did not throw an error when that happened.
This PR makes the error to be thrown properly.

@JohnTitor JohnTitor closed this Jan 12, 2026
@JohnTitor JohnTitor reopened this Jan 12, 2026
@JohnTitor JohnTitor force-pushed the fix/throw-fsevents-stream-start-error-properly branch from 219be54 to 38686d4 Compare January 12, 2026 00:21
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@JohnTitor JohnTitor merged commit 7145793 into notify-rs:main Jan 14, 2026
17 checks passed
@sapphi-red sapphi-red deleted the fix/throw-fsevents-stream-start-error-properly branch January 15, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants