Fix: INotifyWatcher keeps watching deleted paths#720
Merged
JohnTitor merged 3 commits intonotify-rs:mainfrom Jan 12, 2026
Merged
Fix: INotifyWatcher keeps watching deleted paths#720JohnTitor merged 3 commits intonotify-rs:mainfrom
JohnTitor merged 3 commits intonotify-rs:mainfrom
Conversation
JohnTitor
approved these changes
Jan 12, 2026
Member
JohnTitor
left a comment
JohnTitor
left a comment
There was a problem hiding this comment.
Thank you and sorry for the delay! LGTM.
JohnTitor
added a commit
that referenced
this pull request
Jan 16, 2026
Co-authored-by: Yuki Okushi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #709. Full information about the bug are described in the documentation for the
remove_single_descriptormethod.The main problem was, that we tried to remove descriptor from the
inotify.watches(), and, if it was completed successfully, it would be deleted from the hashdescriptor -> path. But after FS entry deletion its file descriptor is invalidated and causes an error, which interrupts deletion from the hash