Merged
Conversation
graphite-app bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Sep 10, 2025
Temporary switch to my fork with a patch (notify-rs/notify#711) until the PR is merged.
JohnTitor
approved these changes
Oct 4, 2025
Member
JohnTitor
left a comment
JohnTitor
left a comment
There was a problem hiding this comment.
Yeah, these events should be consolidated, thanks!
JohnTitor
force-pushed
the
fix/debounce-events
branch
from
453ac66 to
7e6bc51
Compare
JohnTitor
pushed a commit
that referenced
this pull request
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple events happened within the timeout, the events were not deduped.
To explain it more precisely, the return value of
DebounceDataInner::debounced_eventsnever contained a duplicate event, butevent_handlerwas called multiple times for events within the timeout.For example, when the timeout is 8 and the tick rate is 2, consider the following events:
event_handleris called with0: modify eventon 2, and3: modify eventon 4. But these two events are within the timeout so theevent_handlershould be only called with3: modify eventon 12. (It is 12 because that is the first tick after the timeout has passed from the last event)