fix: make PathsMut::commit consuming#695
Merged
JohnTitor merged 1 commit intonotify-rs:mainfrom Jul 2, 2025
Merged
Conversation
branchseer
commented
Jul 2, 2025
| /// Ensure added/removed paths are applied. | ||
| /// | ||
| /// The behaviour of dropping a [`PathsMut`] without calling [`commit`] is unspecified. | ||
| /// The implementation is free to ignore the changes or not, and may leave the watcher in a started or stopped state. |
Contributor
Author
There was a problem hiding this comment.
I don't want the FsEventPathsMut to restart the watcher on drop because we can't return errors from drop. I think it's better to leave the state unspecified.
|
Thanks @branchseer, this addresses all the concerns I had with the original implementation! |
JohnTitor
pushed a commit
that referenced
this pull request
Jul 3, 2025
JohnTitor
pushed a commit
that referenced
this pull request
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures
PathsMut::commitcan only be called once, and adds more docs.fixes concerns at #692 (comment)