Make INotifyWatcher return the native PathNotFound error when watchin…#686
Merged
dfaust merged 2 commits intonotify-rs:mainfrom Jun 1, 2025
Merged
Make INotifyWatcher return the native PathNotFound error when watchin…#686dfaust merged 2 commits intonotify-rs:mainfrom
dfaust merged 2 commits intonotify-rs:mainfrom
Conversation
Contributor
Author
|
@dfaust do you know who i can ask to review this, not really sure how your contributing guidelines are / who to @ just saw that you merged the latest PR about 3 weeks ago |
…g non recursively
Member
|
Could you add a regression test for this case? |
Member
|
Looks good. And yes, a regression test wouldn't hurt. |
Member
|
Thank you! |
JohnTitor
pushed a commit
that referenced
this pull request
Jan 16, 2026
#686) * Make INotifyWatcher return the native PathNotFound error when watching non recursively * add regression test + add entry to changelog --------- Co-authored-by: John Janzen <[email protected]> Co-authored-by: John Janzen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the work started by #611 and closes #685