Merged
Conversation
Member
|
Thanks a bunch. Just one thing. Would you mind adding it to the change log? |
When unwatching a directory that was watched recursively, notify's kqueue impl would first unwatch the containing directory, then walk it to unwatch all the items inside. However, walking the directory first processes the containing directory, and unwatching a directory twice can cause an error in the kqueue crate. Fixes notify-rs#665 and adds a test to prevent regressions.
worr
force-pushed
the
bug/dont-unwatch-twice
branch
from
2a97aea to
c11e831
Compare
Contributor
Author
|
@dfaust Done, let me know if there are issues with the format or anything you want me to change |
Member
|
Thank you! |
JohnTitor
pushed a commit
that referenced
this pull request
Jul 3, 2025
Do not remove a filename twice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When unwatching a directory that was watched recursively, notify's kqueue impl would first unwatch the containing directory, then walk it to unwatch all the items inside.
However, walking the directory first processes the containing directory, and unwatching a directory twice can cause an error in the kqueue crate.
Fixes #665 and adds a test to prevent regressions.