Conversation
Closed
Closed
Closed
dfaust
force-pushed
the
remove-mock-instant
branch
from
c5789de to
ebcd784
Compare
The feature was previously renamed from `crossbeam` to `crossbeam-channel`.
Trying to use mock_instant across multiple crates was a bad idea. All functions requiring a clock were removed from the notify-types crate and custom time mocking functions were added.
dfaust
force-pushed
the
remove-mock-instant
branch
from
ebcd784 to
3bb640f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues:
Trying to use mock_instant across multiple crates was a bad idea. All functions requiring a clock were removed from the notify-types crate and custom time mocking functions were added.
crossbeamfeature was renamed tocrossbeam-channelbut that wasn't updated everywhere.These tests are meant to just test if the watchers work at all, not all of their features. That was tried in previous versions of notify, but lead to very flaky tests.