Fix: Low Res and high Res ID inversion#618
Merged
0xpr03 merged 1 commit intonotify-rs:mainfrom Jul 16, 2024
CalunVier:main
Merged
Fix: Low Res and high Res ID inversion#6180xpr03 merged 1 commit intonotify-rs:mainfrom CalunVier:main
0xpr03 merged 1 commit intonotify-rs:mainfrom
CalunVier:main
Conversation
Contributor
Author
|
Github Action CI has pass in my own repository. I don't know why there were something wrong here. |
Member
|
CI for the BSD runner seems to fail because cirrus doesn't have enough capacity.. |
Member
|
Yes, that's a mistake. Thank you @CalunVier for fixing it! |
|
Just in case, please when releasing update minor version, not patch. So it would be more visible that this is a breaking change. Thanks! |
Member
|
Yeah, has to be for breaking change pre 1.0. Although it is a hotfix to regain the intended behaviour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the get_low_res_file_id() and get_high_res_file_id() functions in the file_id crate are mistakenly calling opposite underlying functions. At least that's how I understand it, there's something wrong here.