Closed
Conversation
Member
|
Let's merge this with #568 as 7.0 and try to get everything else into 6.X Or is there anything else that would be major breaking ? |
Member
Author
|
The change to the event serialization is already in main. And that's breaking. |
Member
|
Ah yeah, my bad. Nevermind then, break all the things. |
Member
|
This also needs a rebase |
`std::sync::mpsc::Sender` implements `Sync` since version 1.72, so there is no need for crossbeam anymore.
Member
|
I'll re-rebase this when I'm back at home (+2days!). Then I wall have to look at the outstanding issues and PR that accumulated over the past ~2 months and push the release finally over the line.. Thanks for all the work! |
Member
Author
|
Can we merge this? I already based my next PR on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::sync::mpsc::SenderimplementsSyncsince version 1.72, so there is no need for crossbeam anymoreI screwed up a bit and this PR is based on my previous on (#567).