Move event types into separate crate#559
Conversation
0xpr03
left a comment
0xpr03
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the work!
Let me know if you want this merged. I'm always unsure whether PRs are "WIP" / informative or actually "ready for merge" when they're opened without any flaws.
|
Please merge it. |
|
I'll do a crate push / release once I'm back home today. |
Sounds good. I've just seen a lot of PRs where in the time it took me to actually review them, they got additional commits for fixups. So I would've prematurely merged stuff if I would've been faster. (Finding typos is something I always do afterwards..) |
|
That's true. Happens to me all the time. And if I can, I fix those issues immediately. But if you merge my PR "too quick", it's still my fault for requesting bad code to be merged. So don't worry - and it can always be fixed later. |
Maybe hold back on that and check #560. |
2 participants
Move event types into separate crate.
Closes #487.