improve first example in the docs#543
Merged
JohnTitor merged 1 commit intonotify-rs:mainfrom Jan 4, 2024
Merged
Conversation
Member
|
this is still blocked by CI failing |
The first example is misleading in that it doesn't show code that will produce a useful example, but instead exits instantly with no standing example of how to usefully get events to the main thread.
mumbleskates
force-pushed
the
doc-example
branch
from
60792f6 to
e044230
Compare
Contributor
Author
|
Thanks, should be unblocked now; i removed the duplicate import it was failing on. |
JohnTitor
approved these changes
Jan 4, 2024
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first example is misleading in that it doesn't show code that will produce a useful example, but instead exits instantly with no standing example of how to usefully get events to the main thread.