Skip to content

refactor: update error names to align with Go convention#529

Merged
shizhMSFT merged 3 commits intonotaryproject:mainfrom
qba73:fix/528-error-types
Apr 11, 2025
Merged

refactor: update error names to align with Go convention#529
shizhMSFT merged 3 commits intonotaryproject:mainfrom
qba73:fix/528-error-types

Conversation

@qba73
Copy link
Copy Markdown
Contributor

@qba73 qba73 commented Apr 2, 2025

This PR fixes #528 and adds the following changes:

  • add new custom errors (naming aligned with Go convention)
  • mark old custom error deprecated

@qba73 qba73 requested a review from a user April 2, 2025 06:51
@qba73 qba73 requested review from vaninrao10 and yizha1 as code owners April 2, 2025 06:51
@FeynmanZhou
Copy link
Copy Markdown
Member

FeynmanZhou commented Apr 3, 2025

@qba73 Thanks for your contribution! Would you mind signing off your git commit? See the details at https://github.com/notaryproject/notation-go/pull/529/checks?check_run_id=39824512392

shizhMSFT
shizhMSFT requested changes Apr 3, 2025
View reviewed changes
@shizhMSFT shizhMSFT changed the title Update error names to align with Go convention refactor: update error names to align with Go convention Apr 3, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.92%. Comparing base (3bd0ac9) to head (3266304).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #529   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files          36       36           
  Lines        3355     3355           
=======================================
  Hits         2715     2715           
  Misses        493      493           
  Partials      147      147

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qba73
Copy link
Copy Markdown
Contributor Author

qba73 commented Apr 4, 2025

@qba73 Thanks for your contribution! Would you mind signing off your git commit? See the details at https://github.com/notaryproject/notation-go/pull/529/checks?check_run_id=39824512392

Done

@qba73
Apply PR feedback
3266304 
Signed-off-by: Jakub Jarosz <[email protected]>
ghost
ghost approved these changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao approved these changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qba73 qba73 requested a review from shizhMSFT April 9, 2025 06:30
shizhMSFT
shizhMSFT approved these changes Apr 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit dbbeca1 into notaryproject:main Apr 11, 2025
9 checks passed
@qba73 qba73 deleted the fix/528-error-types branch April 12, 2025 15:08
@ghost ghost mentioned this pull request Apr 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

+2 more reviewers

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error type needs to follow Golang Convention

4 participants

@qba73 @FeynmanZhou @shizhMSFT @JeyJeyGao