chore: update logs#469
Merged
priteshbandi merged 7 commits intomainfrom Oct 16, 2024
unknown repository
Merged
Conversation
Signed-off-by: Patrick Zheng <[email protected]>
ghost
requested review from
JeyJeyGao,
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
==========================================
+ Coverage 81.34% 81.63% +0.29%
==========================================
Files 34 34
Lines 2578 2581 +3
==========================================
+ Hits 2097 2107 +10
+ Misses 335 328 -7
Partials 146 146 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
added 2 commits
October 9, 2024 15:53
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Contributor
priteshbandi
left a comment
priteshbandi
left a comment
There was a problem hiding this comment.
LGTM with a comment
Signed-off-by: Patrick Zheng <[email protected]>
This was referenced Dec 9, 2024
ghost
pushed a commit
that referenced
this pull request
Dec 10, 2024
Signed-off-by: Patrick Zheng <[email protected]>
This was referenced Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates logs.
Resolves #430. Also should resolve issue notaryproject/notation#1004.