Skip to content

fix: quick fix typo in error msg#328

Merged
priteshbandi merged 1 commit intomainfrom
unknown repository
Jul 1, 2023
Merged

fix: quick fix typo in error msg#328
priteshbandi merged 1 commit intomainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jun 30, 2023

No description provided.

Signed-off-by: Patrick Zheng <[email protected]>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 30, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.80%. Comparing base (432c931) to head (80ee2e1).
⚠️ Report is 136 commits behind head on main.

❌ Your project status has failed because the head coverage (74.80%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   74.80%   74.80%           
=======================================
  Files          23       23           
  Lines        2203     2203           
=======================================
  Hits         1648     1648           
  Misses        437      437           
  Partials      118      118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
Copy link
Copy Markdown
Contributor

@Two-Hearts Should we scan all three repos for sing?

@ghost
Copy link
Copy Markdown
Author

ghost commented Jun 30, 2023

@Two-Hearts Should we scan all three repos for sing?

@shizhMSFT good idea, I will scan the other two repos next Monday. For notation-go, I've already done that.

Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 2882baf into notaryproject:main Jul 1, 2023
@ghost ghost deleted the fix branch July 3, 2023 00:58
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants