Skip to content

doc: add blob policy init command#1197

Merged
yizha1 merged 8 commits intonotaryproject:mainfrom
yizha1:doc-blobpolicyinit
Mar 5, 2025
Merged

doc: add blob policy init command#1197
yizha1 merged 8 commits intonotaryproject:mainfrom
yizha1:doc-blobpolicyinit

Conversation

@yizha1
Copy link
Copy Markdown
Contributor

@yizha1 yizha1 commented Mar 2, 2025

Update:

  • Add notation blob policy init spec per the proposal

Signed-off-by: Yi Zha [email protected]

yizha1 added 2 commits March 1, 2025 21:03
Signed-off-by: Yi Zha (from Dev Box) <[email protected]>
Signed-off-by: Yi Zha (from Dev Box) <[email protected]>
@yizha1 yizha1 requested a review from a user March 2, 2025 05:09
@yizha1 yizha1 requested a review from vaninrao10 as a code owner March 2, 2025 05:09
yizha1 added 2 commits March 1, 2025 21:12
Signed-off-by: Yi Zha (from Dev Box) <[email protected]>
Signed-off-by: Yi Zha (from Dev Box) <[email protected]>
@yizha1 yizha1 requested a review from JeyJeyGao March 3, 2025 22:58
@yizha1
Copy link
Copy Markdown
Contributor Author

yizha1 commented Mar 3, 2025

@JeyJeyGao your comments were resolved.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.22%. Comparing base (1e5e342) to head (83070b9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1197   +/-   ##
=======================================
  Coverage   76.22%   76.22%           
=======================================
  Files          71       71           
  Lines        3634     3634           
=======================================
  Hits         2770     2770           
  Misses        668      668           
  Partials      196      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JeyJeyGao
JeyJeyGao previously approved these changes Mar 4, 2025
Copy link
Copy Markdown
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestion

shizhMSFT
shizhMSFT previously approved these changes Mar 4, 2025
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Yi Zha (from Dev Box) <[email protected]>
@yizha1 yizha1 dismissed stale reviews from shizhMSFT and JeyJeyGao via 83070b9 March 4, 2025 16:08
@yizha1
Copy link
Copy Markdown
Contributor Author

yizha1 commented Mar 4, 2025

@JeyJeyGao @shizhMSFT @vaninrao10 would you mind reviewing this PR?

Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 merged commit 390e69e into notaryproject:main Mar 5, 2025
7 checks passed
@yizha1 yizha1 deleted the doc-blobpolicyinit branch March 5, 2025 17:01
JeyJeyGao added a commit that referenced this pull request Mar 11, 2025
This PR implements #1197 

Feat:
- added `blob policy init` comamnd

Docs:
- fixed the `blob-signing.md` spec

Test:
- added E2E

---------

Signed-off-by: Junjie Gao <[email protected]>
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Update:

- Add `notation blob policy init` spec per the proposal

Signed-off-by: Yi Zha <[email protected]>

---------

Signed-off-by: Yi Zha (from Dev Box) <[email protected]>
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
This PR implements notaryproject#1197 

Feat:
- added `blob policy init` comamnd

Docs:
- fixed the `blob-signing.md` spec

Test:
- added E2E

---------

Signed-off-by: Junjie Gao <[email protected]>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Update:

- Add `notation blob policy init` spec per the proposal

Signed-off-by: Yi Zha <[email protected]>

---------

Signed-off-by: Yi Zha (from Dev Box) <[email protected]>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
This PR implements notaryproject#1197 

Feat:
- added `blob policy init` comamnd

Docs:
- fixed the `blob-signing.md` spec

Test:
- added E2E

---------

Signed-off-by: Junjie Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants