Skip to content

fix: output in streaming fashion for inspect command in tree format#1194

Merged
JeyJeyGao merged 3 commits intonotaryproject:mainfrom
JeyJeyGao:fix/streaming_inspect
Feb 27, 2025
Merged

fix: output in streaming fashion for inspect command in tree format#1194
JeyJeyGao merged 3 commits intonotaryproject:mainfrom
JeyJeyGao:fix/streaming_inspect

Conversation

@JeyJeyGao
Copy link
Copy Markdown
Contributor

@JeyJeyGao JeyJeyGao commented Feb 27, 2025

The inspect command can now output in streaming fashion in tree format. Previously, the inspect command in tree format could only output when all signatures were read, which was not user-friendly when there were many signatures, and users had to wait for a while for the output.

@JeyJeyGao JeyJeyGao changed the title fix: output in streaming fasion for inspect command fix: output in streaming fashion for inspect command Feb 27, 2025
@JeyJeyGao JeyJeyGao changed the title fix: output in streaming fashion for inspect command fix: output in streaming fashion for inspect command in tree format Feb 27, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.22%. Comparing base (ba4c018) to head (d2ffd56).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
+ Coverage   76.08%   76.22%   +0.14%     
==========================================
  Files          71       71              
  Lines        3625     3634       +9     
==========================================
+ Hits         2758     2770      +12     
+ Misses        670      668       -2     
+ Partials      197      196       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao marked this pull request as ready for review February 27, 2025 02:50
@JeyJeyGao JeyJeyGao requested a review from a user February 27, 2025 02:50
@JeyJeyGao JeyJeyGao marked this pull request as draft February 27, 2025 02:52
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao marked this pull request as ready for review February 27, 2025 03:16
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 1e5e342 into notaryproject:main Feb 27, 2025
7 checks passed
@JeyJeyGao JeyJeyGao deleted the fix/streaming_inspect branch February 27, 2025 05:23
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
…at (notaryproject#1194)

The `inspect` command can now output in streaming fashion in `tree`
format. Previously, the `inspect` command in `tree` format could only
output when all signatures were read, which was not user-friendly when
there were many signatures, and users had to wait for a while for the
output.

---------

Signed-off-by: Junjie Gao <[email protected]>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
…at (notaryproject#1194)

The `inspect` command can now output in streaming fashion in `tree`
format. Previously, the `inspect` command in `tree` format could only
output when all signatures were read, which was not user-friendly when
there were many signatures, and users had to wait for a while for the
output.

---------

Signed-off-by: Junjie Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants