`CLOSED` messages for relays that want to reject REQs and NIP-42 `AUTH` integration by fiatjaf · Pull Request #902 · nostr-protocol/nips

fiatjaf · 2023-11-27T18:46:23Z

I will quote my own message from #841 (comment) to explain this:

Basically we have two distinct problems:

knowing why a relay is asking for AUTH

knowing why a subscription has failed

adding a third element to AUTH only solves them in the occasion that the two happen together.

creating a new message solves 2 and making AUTH be subservient to that (and also to OK) solves 1.

More relevant messages were posted to that other thread but should probably have been posted to this.

…ntegration.

01.md

42.md

monlovesmango · 2023-11-27T19:06:53Z

some minor changes, but I approve.

personally think we should just use "CLOSE" rather than "CLOSED" to mirror the client side "CLOSE" (in the same way that "EVENT" is the same on client and relay sides and mean the same thing). seems way more consistent to me.

ps. really like the "CLOSE" verb over the ones that I suggested

Co-authored-by: monlovesmango <[email protected]>

fiatjaf · 2023-11-27T19:18:17Z

My rationale for CLOSED was that when a client is sending a CLOSE it is requesting the relay to close the subscription, but when a relay sends it it is just notifying the client that it has already been done.

Also I prefer to have different words, makes the parsing code simpler.

01.md

arthurfranca · 2023-11-27T19:52:39Z

ACK!! The flow is very clear now with examples and all.

Personally I would just tell relays to always send AUTH right after connection is established. It leaves less room for errors (like sending CLOSED/OK before AUTH).

42.md

proudmuslim-dev · 2023-11-27T19:52:03Z

42.md

+This NIP defines two new prefixes that can be used in `OK` (in response to event writes by clients) and `CLOSED` (in response to rejected
+subscriptions by clients):
+
+- `"auth-required: "` - for when a client has not performed `AUTH` and the relay requires that to fulfill the query or write the event.


Suggested change

- `"auth-required: "` - for when a client has not performed `AUTH` and the relay requires that to fulfill the query or write the event.

- `"auth-required: "` - for when a client has not performed `AUTH` and the relay requires it to fulfill the query or write the event.

staab · 2023-11-27T20:06:42Z

From #841 (comment)

I think it won't hurt at all to have a message akin to OK but specifically for REQs.

This makes sense. We could probably use the same verb for COUNT and other future read-verbs like HASH too? Not necessary to specify, just a thought.

jb55

LGTM

monlovesmango · 2023-11-27T21:06:51Z

should this also apply to nip 45?

mikedilger · 2023-11-28T18:58:07Z

+1

proudmuslim-dev · 2023-11-28T22:32:41Z

42.md

-At any moment the relay may send an `AUTH` message to the client containing a challenge. After receiving that the client may decide to
-authenticate itself or not. The challenge is expected to be valid for the duration of the connection or until a next challenge is sent by
-the relay.
+At any moment the relay may send an `AUTH` message to the client containing a challenge. The challenge is valid for the duration of the connection or until another challenge is sent by the relay. The client MAY decide to send its `AUTH` event at any point and the authenticated session is valid afterwards for the duration of the connection.


Suggested change

At any moment the relay may send an `AUTH` message to the client containing a challenge. The challenge is valid for the duration of the connection or until another challenge is sent by the relay. The client MAY decide to send its `AUTH` event at any point and the authenticated session is valid afterwards for the duration of the connection.

At any moment the relay may send an `AUTH` message to the client containing a challenge. The challenge is valid for the duration of the connection or until another challenge is sent by the relay. The client MAY decide to send its `AUTH` event at any point and the authenticated session is then valid for the remainder of the connection.

fiatjaf · 2023-11-29T11:08:50Z

Implemented in https://github.com/nbd-wtf/go-nostr and https://github.com/fiatjaf/khatru.

fiatjaf · 2023-11-29T16:29:11Z

Implemented in https://nostr.wine

nostr-wine · 2023-11-29T16:32:02Z

Ha - you beat me to it. We implemented CLOSED with the new flow for DM REQs on all nostr.wine regional relays and will work on the rest of our relays today.

…H` integration (nostr-protocol#902) Co-authored-by: monlovesmango <[email protected]>

CLOSED messages for relays that want to reject REQs and NIP-42 AUTH i…

2727368

…ntegration.

fiatjaf mentioned this pull request Nov 27, 2023

Add AUTH third element #841

Closed

monlovesmango suggested changes Nov 27, 2023

View reviewed changes

01.md Outdated Show resolved Hide resolved

42.md Outdated Show resolved Hide resolved

42.md Outdated Show resolved Hide resolved

fiatjaf and others added 3 commits November 27, 2023 16:16

fix phrase

238524e

Co-authored-by: monlovesmango <[email protected]>

fix phrase

c417370

Co-authored-by: monlovesmango <[email protected]>

clarify

214f3cb

Co-authored-by: monlovesmango <[email protected]>

monlovesmango approved these changes Nov 27, 2023

View reviewed changes

monlovesmango mentioned this pull request Nov 27, 2023

NIP-42 - Allow client to ask for the challenge #891

Closed

proudmuslim-dev reviewed Nov 27, 2023

View reviewed changes

01.md Outdated Show resolved Hide resolved

proudmuslim-dev suggested changes Nov 27, 2023

View reviewed changes

arthurfranca mentioned this pull request Nov 27, 2023

NIP-43 - Fast Authentication #571

Closed

staab approved these changes Nov 27, 2023

View reviewed changes

jb55 self-requested a review November 27, 2023 20:10

jb55 approved these changes Nov 27, 2023

View reviewed changes

fiatjaf added 4 commits November 28, 2023 17:13

fix formatting and a phrase.

1e3b67b

mention CLOSED message in NIP-45.

becfd74

bring back this.

0674fc0

get rid of the annoying hard line breaks.

022f1c5

proudmuslim-dev suggested changes Nov 28, 2023

View reviewed changes

use the same standardized prefixes for OK and CLOSED.

26599a3

staab mentioned this pull request Nov 29, 2023

Implement CLOSED coracle-social/coracle#204

Closed

mikedilger mentioned this pull request Nov 29, 2023

Implement CLOSED mikedilger/gossip#577

Closed

fiatjaf merged commit 2bd4bf7 into master Dec 6, 2023

fiatjaf deleted the closed branch December 6, 2023 15:01

arthurfranca mentioned this pull request Feb 21, 2024

Add Private Event Kind Range to NIP-42 #1049

Closed

alexgleason mentioned this pull request Jan 23, 2025

Strfry should send CLOSED for invalid messages hoytech/strfry#135

Closed

alexgleason mentioned this pull request Feb 13, 2025

Remove NOTICE relay messages from NIP-01 #1783

Open

RandyMcMillan pushed a commit to gnostr-org/gnostr-nips that referenced this pull request Apr 5, 2025

CLOSED messages for relays that want to reject REQs and NIP-42 `AUT…

0d21698

…H` integration (nostr-protocol#902) Co-authored-by: monlovesmango <[email protected]>

	- `"auth-required: "` - for when a client has not performed `AUTH` and the relay requires that to fulfill the query or write the event.
	- `"auth-required: "` - for when a client has not performed `AUTH` and the relay requires it to fulfill the query or write the event.

	At any moment the relay may send an `AUTH` message to the client containing a challenge. The challenge is valid for the duration of the connection or until another challenge is sent by the relay. The client MAY decide to send its `AUTH` event at any point and the authenticated session is valid afterwards for the duration of the connection.
	At any moment the relay may send an `AUTH` message to the client containing a challenge. The challenge is valid for the duration of the connection or until another challenge is sent by the relay. The client MAY decide to send its `AUTH` event at any point and the authenticated session is then valid for the remainder of the connection.

Conversation

fiatjaf commented Nov 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

monlovesmango commented Nov 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fiatjaf commented Nov 27, 2023

Uh oh!

Uh oh!

arthurfranca commented Nov 27, 2023

Uh oh!

Uh oh!

proudmuslim-dev Nov 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

staab commented Nov 27, 2023

Uh oh!

jb55 left a comment

Choose a reason for hiding this comment

Uh oh!

monlovesmango commented Nov 27, 2023

Uh oh!

mikedilger commented Nov 28, 2023

Uh oh!

proudmuslim-dev Nov 28, 2023

Choose a reason for hiding this comment

Uh oh!

fiatjaf commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fiatjaf commented Nov 29, 2023

Uh oh!

nostr-wine commented Nov 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

fiatjaf commented Nov 27, 2023 •

edited

Loading

monlovesmango commented Nov 27, 2023 •

edited

Loading

proudmuslim-dev Nov 27, 2023 •

edited

Loading

fiatjaf commented Nov 29, 2023 •

edited

Loading