Skip to content

Add nip for key sharing#876

Closed
staab wants to merge 1 commit intonostr-protocol:masterfrom
coracle-social:key-sharing
Closed

Add nip for key sharing#876
staab wants to merge 1 commit intonostr-protocol:masterfrom
coracle-social:key-sharing

Conversation

@staab
Copy link
Copy Markdown
Member

@staab staab commented Nov 10, 2023

This PR adds a simple scheme for sharing keys, including simple rotation that supports weak forward secrecy. This is a prerequisite to #875.

@staab staab requested a review from fiatjaf November 10, 2023 20:36
@staab staab mentioned this pull request Nov 10, 2023
@staab staab marked this pull request as draft November 10, 2023 20:37
@fiatjaf
Copy link
Copy Markdown
Member

fiatjaf commented Nov 10, 2023

I think this should be inside NIP-87.

@staab
Copy link
Copy Markdown
Member Author

staab commented Nov 10, 2023

I didn't include it because I think it has other use cases, for example something like water783's alias exchange.

@fiatjaf
Copy link
Copy Markdown
Member

fiatjaf commented Nov 10, 2023

That's premature modularization.

Once NIP-87 exists the alias exchange NIP can just say "we share keys like in NIP-87" and then proceed to describe the added differences.

I don't know.

@staab
Copy link
Copy Markdown
Member Author

staab commented Nov 10, 2023

Yeah, that's fair. I do think it's clearer to separate the concerns anyway, but I have no real objection to merging the nips.

@staab staab closed this Nov 14, 2023
@staab staab deleted the key-sharing branch January 31, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants