NIP05: warn about CORS policies that may inhibit JS apps#4
Merged
fiatjaf merged 1 commit intonostr-protocol:masterfrom May 7, 2022
Merged
NIP05: warn about CORS policies that may inhibit JS apps#4fiatjaf merged 1 commit intonostr-protocol:masterfrom
fiatjaf merged 1 commit intonostr-protocol:masterfrom
Conversation
JS Nostr apps such as Branle may not be able to load `nostr.json` files due to CORS policies. Update NIP05 to warn about this and provide hints for troubleshooting and fixing the issue.
Contributor
|
ACK |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS Nostr apps such as Branle may not be able to load
nostr.jsonfiles due to CORS policies. Update NIP05 to warn about this and provide hints for troubleshooting and fixing the issue.I think this is the best way to address a confusion I had trying to add my NIP05 identifier to a Branle instance where I kept receiving an error. It also implies that other Nostr apps may be able to load
nostr.jsonfiles that Branle and other pure-JS apps won't be able to load, which may produce some user confusion.Note: I'm not a webdev, I might not be describing CORS stuff accurately.