feat(browser): new icons and exchange link#947
Merged
jeroenptrs merged 3 commits intodevelopfrom Mar 30, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #947 +/- ##
==========================================
+ Coverage 52.47% 52.5% +0.02%
==========================================
Files 240 240
Lines 2039 2040 +1
Branches 277 278 +1
==========================================
+ Hits 1070 1071 +1
Misses 802 802
Partials 167 167 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #947 +/- ##
==========================================
+ Coverage 52.47% 52.5% +0.02%
==========================================
Files 240 240
Lines 2039 2040 +1
Branches 277 278 +1
==========================================
+ Hits 1070 1071 +1
Misses 802 802
Partials 167 167 |
jeroenptrs
force-pushed
the
feat/newIcons
branch
from
ddf7069 to
d026487
Compare
jeroenptrs
force-pushed
the
feat/newIcons
branch
from
d026487 to
d417f00
Compare
DalderupMaurice
approved these changes
Mar 30, 2019
DalderupMaurice
added
PR: good to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds new icons and enables Nash as exchange in the sidebar. Also changed the order of the sidebar.
Motivation and Context
With Nash launching soon it makes sense to enable the exchange part of the nOS browser.
How Has This Been Tested?
Imported the icons and looked if they're ok
Screenshots (if appropriate)
Types of changes
Checklist
Documentation
Closing issues
Fixes #