Skip to content

feat(app): added legacy import link and added fetch balances on mount#1361

Merged
DalderupMaurice merged 12 commits intodevelopfrom
feat/balance-and-legacy
Aug 22, 2020
Merged

feat(app): added legacy import link and added fetch balances on mount#1361
DalderupMaurice merged 12 commits intodevelopfrom
feat/balance-and-legacy

Conversation

@DalderupMaurice
Copy link
Copy Markdown
Member

@DalderupMaurice DalderupMaurice commented Aug 10, 2020 •
edited
Loading

Description

  • Added returning user link below login/register field
  • Fetch balances when portfolio tab mounts
  • Moved fetching of balances on new blocks app-wide, removing the onmount balance fetch, which crashed the app

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 10, 2020 •
edited
Loading

Codecov Report

Merging #1361 into develop will increase coverage by 0.02%.
The diff coverage is 57.14%.

@@             Coverage Diff             @@
##           develop    #1361      +/-   ##
===========================================
+ Coverage    49.53%   49.55%   +0.02%     
===========================================
  Files          249      249              
  Lines         2150     2153       +3     
===========================================
+ Hits          1065     1067       +2     
- Misses        1085     1086       +1

deanpress
deanpress approved these changes Aug 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@deanpress deanpress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DalderupMaurice DalderupMaurice merged commit 386d7f2 into develop Aug 22, 2020
@DalderupMaurice DalderupMaurice deleted the feat/balance-and-legacy branch August 22, 2020 06:52
@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deanpress deanpress deanpress approved these changes

Assignees

No one assigned

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DalderupMaurice @deanpress