Skip to content

chore(AppContainer): fix white flicker when opening tab#1102

Merged
DalderupMaurice merged 3 commits intodevelopfrom
chore/fix-white-flicker
Aug 15, 2019
Merged

chore(AppContainer): fix white flicker when opening tab#1102
DalderupMaurice merged 3 commits intodevelopfrom
chore/fix-white-flicker

Conversation

@DalderupMaurice
Copy link
Copy Markdown
Member

@DalderupMaurice DalderupMaurice commented Aug 15, 2019

Description

Fixes the issue where opening a new tab would flicker white before the page was loaded

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@DalderupMaurice DalderupMaurice added the PR: needs review Pull request label Aug 15, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 15, 2019 •
edited
Loading

Codecov Report

Merging #1102 into develop will increase coverage by 0.07%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1102      +/-   ##
===========================================
+ Coverage    50.77%   50.84%   +0.07%     
===========================================
  Files          240      240              
  Lines         2062     2065       +3     
  Branches       275      276       +1     
===========================================
+ Hits          1047     1050       +3     
  Misses         843      843              
  Partials       172      172

@jeroenptrs jeroenptrs added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Aug 15, 2019
@DalderupMaurice DalderupMaurice merged commit 5b304c8 into develop Aug 15, 2019
@DalderupMaurice DalderupMaurice deleted the chore/fix-white-flicker branch August 15, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jeroenptrs jeroenptrs jeroenptrs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DalderupMaurice @jeroenptrs