chore(appContainer): adds a default bg color to the webview page#1071
Merged
DalderupMaurice merged 1 commit intodevelopfrom Aug 10, 2019
Merged
chore(appContainer): adds a default bg color to the webview page#1071DalderupMaurice merged 1 commit intodevelopfrom
DalderupMaurice merged 1 commit intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1071 +/- ##
========================================
Coverage 51.04% 51.04%
========================================
Files 238 238
Lines 2061 2061
Branches 275 275
========================================
Hits 1052 1052
Misses 838 838
Partials 171 171 |
deanpress
approved these changes
Aug 10, 2019
DalderupMaurice
added
PR: good to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a default bg color to the webview page.
Viewing js/json/files in common in the nOS Browser has a weird gray color by default, rendering text not readable.
This PR fixes this by setting a default color as white for these pages.
Motivation and Context
Text of files was unreadable
How Has This Been Tested?
Screenshots (if appropriate)
Types of changes
Checklist
Documentation
Closing issues
Fixes #