chore(wallet): fix encrypted input not working and add color fallback#1057
Merged
DalderupMaurice merged 2 commits intodevelopfrom Aug 4, 2019
Merged
chore(wallet): fix encrypted input not working and add color fallback#1057DalderupMaurice merged 2 commits intodevelopfrom
DalderupMaurice merged 2 commits intodevelopfrom
Conversation
also cleaned up some props
DalderupMaurice
commented
Aug 3, 2019
|
|
||
| const coinType = COINS[wallet.coinType]; | ||
| const identityColor = styles[coinType ? coinType.symbol.toLowerCase() : DEFAULT_COIN]; | ||
| // TODO dont hardcode fallback color |
Member
Author
There was a problem hiding this comment.
this is something we'll do when nOS has it's native coin. As we cannot include it yet in the coins consts for this reason
Codecov Report
@@ Coverage Diff @@
## develop #1057 +/- ##
==========================================
- Coverage 51.02% 51% -0.03%
==========================================
Files 238 238
Lines 2046 2047 +1
Branches 271 271
==========================================
Hits 1044 1044
- Misses 833 834 +1
Partials 169 169 |
jeroenptrs
approved these changes
Aug 3, 2019
| try { | ||
| if (wallet) { | ||
| const walletInstance = Wallet({ encryptedMnemonic: data, passphrase, wallet }); | ||
| const walletInstance = await Wallet({ encryptedMnemonic: data, passphrase, wallet }); |
Contributor
There was a problem hiding this comment.
Would be nice if this was an actual class, but not relevant to this PR
Member
Author
There was a problem hiding this comment.
you cannot await new Wallet(), right :P That's what I meant with refactoring it to be sync
jeroenptrs
added
PR: good to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also cleaned up some props
Description
fixes an issue with the encrypted input, which went bork due to bip39 updates
Motivation and Context
it was broken
How Has This Been Tested?
Screenshots (if appropriate)
Types of changes
Checklist
Documentation
Closing issues
Fixes #