Skip to content

chore(account): key mgmt view ui fixes#1052

Merged
DalderupMaurice merged 1 commit intodevelopfrom
chore/account-ui-fixes
Aug 1, 2019
Merged

chore(account): key mgmt view ui fixes#1052
DalderupMaurice merged 1 commit intodevelopfrom
chore/account-ui-fixes

Conversation

@jeroenptrs
Copy link
Copy Markdown
Contributor

@jeroenptrs jeroenptrs commented Jul 31, 2019

Description

  • Keychain seed didn't have fluid width.
  • It kept saying "Show & Unlock" even after unlocking

Motivation and Context

UI fixes

How Has This Been Tested?

It works! 😄

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@jeroenptrs jeroenptrs added this to the 0.6.0 milestone Jul 31, 2019
@jeroenptrs jeroenptrs self-assigned this Jul 31, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 31, 2019

Codecov Report

Merging #1052 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1052   +/-   ##
========================================
  Coverage    51.48%   51.48%           
========================================
  Files          237      237           
  Lines         2016     2016           
  Branches       267      267           
========================================
  Hits          1038     1038           
  Misses         813      813           
  Partials       165      165

1 similar comment
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 31, 2019

Codecov Report

Merging #1052 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1052   +/-   ##
========================================
  Coverage    51.48%   51.48%           
========================================
  Files          237      237           
  Lines         2016     2016           
  Branches       267      267           
========================================
  Hits          1038     1038           
  Misses         813      813           
  Partials       165      165

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Aug 1, 2019
@DalderupMaurice DalderupMaurice merged commit 2918150 into develop Aug 1, 2019
@DalderupMaurice DalderupMaurice deleted the chore/account-ui-fixes branch August 1, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DalderupMaurice DalderupMaurice DalderupMaurice approved these changes

@deanpress deanpress Awaiting requested review from deanpress

Assignees

@jeroenptrs jeroenptrs

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Milestone

0.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jeroenptrs @DalderupMaurice